Skip to content

Reduce constants to NF before specialisation (copy #3130) #3144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mergify wants to merge 1 commit into from
Closed

Reduce constants to NF before specialisation (copy #3130) #3144

mergify wants to merge 1 commit into from
+48 −5

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Feb 9, 2026

Basically the implementation @christiaanb gave in #3129 with an added test in the testsuite.

Fixes #3129

Still TODO:

  • Write a changelog entry (see changelog/README.md)
  • Check copyright notices are up to date in edited files
This is an automatic copy of pull request #3130 done by [Mergify](https://mergify.com).

@mergify
Copy link
Contributor Author

mergify bot commented Feb 9, 2026

Cherry-pick of 2ad5b61 has failed:

On branch mergify/copy/1.8/pr-3130
Your branch is up to date with 'origin/1.8'.

You are currently cherry-picking commit 2ad5b613.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   changelog/2026-01-29T18_10_05+01_00_fix_3129
	modified:   tests/Main.hs
	new file:   tests/shouldwork/TopEntity/T3129.hs

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   clash-lib/src/Clash/Normalize/Transformations/Specialize.hs

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot added the conflicts label Feb 9, 2026
@rowanG077
FIXED: Reduce constants to NF before specialisation [#3129](#3129) (#…
43f0583 
…3130)

(cherry picked from commit 2ad5b61)

# Conflicts:
#	clash-lib/src/Clash/Normalize/Transformations/Specialize.hs
@rowanG077 rowanG077 force-pushed the mergify/copy/1.8/pr-3130 branch from 2f83b56 to 43f0583 Compare February 10, 2026 08:29
@rowanG077
Copy link
Member

rowanG077 commented Feb 10, 2026

Testcase doesn't work on older GHC. I don't want to spend too much time on this backport so I will close it.

@rowanG077 rowanG077 closed this Feb 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

conflicts

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@rowanG077